From 9ecc32998f564f894750c391ce6e6edcdc67dfe4 Mon Sep 17 00:00:00 2001 From: David Barton Date: Sun, 7 Feb 2021 23:28:25 +0100 Subject: [PATCH 1/3] docs(contributing): fix typo around test directory link --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a32c126c9bbd3..b886f482a5d10 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -183,7 +183,7 @@ There are additional considerations for dependencies that are environment agonis - Tests should not depend on external services. - Tests should work on all three platforms: Mac, Linux and Win. This is especially important for screenshot tests. -Puppeteer tests are located in the test directory ([`test`](https://github.com/puppeteer/puppeteer/blob/main/test/) and are written using Mocha. See [`test/README.md`](https://github.com/puppeteer/puppeteer/blob/main/test/) for more details. +Puppeteer tests are located in the [`test`](https://github.com/puppeteer/puppeteer/blob/main/test/) directory and are written using Mocha. See [`test/README.md`](https://github.com/puppeteer/puppeteer/blob/main/test/) for more details. Despite being named 'unit', these are integration tests, making sure public API methods and events work as expected. From 05e087e685165eef3c47aace1fdb04d234481f86 Mon Sep 17 00:00:00 2001 From: David Barton Date: Sun, 7 Feb 2021 23:44:11 +0100 Subject: [PATCH 2/3] docs(contributing): specify README.md link --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b886f482a5d10..08c0d3e08a841 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -183,7 +183,7 @@ There are additional considerations for dependencies that are environment agonis - Tests should not depend on external services. - Tests should work on all three platforms: Mac, Linux and Win. This is especially important for screenshot tests. -Puppeteer tests are located in the [`test`](https://github.com/puppeteer/puppeteer/blob/main/test/) directory and are written using Mocha. See [`test/README.md`](https://github.com/puppeteer/puppeteer/blob/main/test/) for more details. +Puppeteer tests are located in the [`test`](https://github.com/puppeteer/puppeteer/blob/main/test/) directory and are written using Mocha. See [`test/README.md`](https://github.com/puppeteer/puppeteer/blob/main/test/README.md) for more details. Despite being named 'unit', these are integration tests, making sure public API methods and events work as expected. From 19fddcfef967ab6fad8b99a35b750847f86866f8 Mon Sep 17 00:00:00 2001 From: Mathias Bynens Date: Mon, 8 Feb 2021 07:37:26 +0100 Subject: [PATCH 3/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 08c0d3e08a841..992efb45b96ed 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -183,7 +183,7 @@ There are additional considerations for dependencies that are environment agonis - Tests should not depend on external services. - Tests should work on all three platforms: Mac, Linux and Win. This is especially important for screenshot tests. -Puppeteer tests are located in the [`test`](https://github.com/puppeteer/puppeteer/blob/main/test/) directory and are written using Mocha. See [`test/README.md`](https://github.com/puppeteer/puppeteer/blob/main/test/README.md) for more details. +Puppeteer tests are located in [the `test` directory](https://github.com/puppeteer/puppeteer/blob/main/test/) and are written using Mocha. See [`test/README.md`](https://github.com/puppeteer/puppeteer/blob/main/test/README.md) for more details. Despite being named 'unit', these are integration tests, making sure public API methods and events work as expected.