From 0616bb046e0c26b9d1c967e49fd46cf88df16c8c Mon Sep 17 00:00:00 2001 From: Henrik Skupin Date: Mon, 11 Oct 2021 09:46:56 +0200 Subject: [PATCH 1/4] chore: run Firefox unit tests only --- .github/workflows/main.yml | 100 ++++++++++++++++++------------------- 1 file changed, 49 insertions(+), 51 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f15c876f0a3be..f536744f95494 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -43,36 +43,34 @@ jobs: run: | npm run build - - name: Run code checks - run: | - npm run ensure-pinned-deps - npm run lint - # Skipping as it's flakey and we are not currently using the new documentation site in the wild yet. - # See https://github.com/puppeteer/puppeteer/issues/7710 for more info - # npm run generate-docs - npm run ensure-correct-devtools-protocol-revision - npm run test-types-file - - - name: Run commit lint - run: | - npm run commitlint - if: github.event_name != 'pull_request' - - - name: Run unit tests - uses: nick-invision/retry@v2 - env: - CHROMIUM: true - with: - max_attempts: 3 - command: xvfb-run --auto-servernum npm run unit - timeout_minutes: 10 - - - name: Run unit tests with coverage - env: - CHROMIUM: true - run: | - xvfb-run --auto-servernum npm run unit-with-coverage - xvfb-run --auto-servernum npm run assert-unit-coverage + # - name: Run code checks + # run: | + # npm run ensure-pinned-deps + # npm run lint + # npm run generate-docs + # npm run ensure-correct-devtools-protocol-revision + # npm run test-types-file + + # - name: Run commit lint + # run: | + # npm run commitlint + # if: github.event_name != 'pull_request' + + # - name: Run unit tests + # uses: nick-invision/retry@v2 + # env: + # CHROMIUM: true + # with: + # max_attempts: 3 + # command: xvfb-run --auto-servernum npm run unit + # timeout_minutes: 10 + + # - name: Run unit tests with coverage + # env: + # CHROMIUM: true + # run: | + # xvfb-run --auto-servernum npm run unit-with-coverage + # xvfb-run --auto-servernum npm run assert-unit-coverage - name: Run unit tests on Firefox uses: nick-invision/retry@v2 @@ -84,18 +82,18 @@ jobs: timeout_minutes: 10 command: xvfb-run --auto-servernum npm run funit - - name: Run browser tests - run: | - npm run test-browser + # - name: Run browser tests + # run: | + # npm run test-browser - - name: Test bundling and installation - env: - CHROMIUM: true - run: | - # Note: this modifies package.json to test puppeteer-core. - npm run test-install - # Undo those changes. - git checkout --force + # - name: Test bundling and installation + # env: + # CHROMIUM: true + # run: | + # # Note: this modifies package.json to test puppeteer-core. + # npm run test-install + # # Undo those changes. + # git checkout --force macos: # https://github.com/actions/virtual-environments#available-environments @@ -125,11 +123,11 @@ jobs: run: | npm run build - - name: Run unit tests - env: - CHROMIUM: true - run: | - npm run unit + # - name: Run unit tests + # env: + # CHROMIUM: true + # run: | + # npm run unit - name: Run unit tests on Firefox uses: nick-invision/retry@v2 @@ -168,11 +166,11 @@ jobs: run: | npm run build - - name: Run unit tests - env: - CHROMIUM: true - run: | - npm run unit + # - name: Run unit tests + # env: + # CHROMIUM: true + # run: | + # npm run unit - name: Run unit tests on Firefox uses: nick-invision/retry@v2 From b78ead7bebf2cbdfcb3eb400327d54e448a98334 Mon Sep 17 00:00:00 2001 From: Henrik Skupin Date: Mon, 11 Oct 2021 09:52:40 +0200 Subject: [PATCH 2/4] chore: don't continue on error for Firefox unit tests on Windows --- .github/workflows/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f536744f95494..59745924a2bb4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -174,7 +174,6 @@ jobs: - name: Run unit tests on Firefox uses: nick-invision/retry@v2 - continue-on-error: true env: FIREFOX: true MOZ_WEBRENDER: 0 From 548e57bfc30912ad8488236796bafafd5480445f Mon Sep 17 00:00:00 2001 From: Henrik Skupin Date: Tue, 26 Apr 2022 08:16:35 +0200 Subject: [PATCH 3/4] chore: add puppeteer debug output --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 59745924a2bb4..df9da94b19e4f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -177,6 +177,7 @@ jobs: env: FIREFOX: true MOZ_WEBRENDER: 0 + DEBUG: puppeteer.* with: max_attempts: 3 timeout_minutes: 10 From db78cb2e020458fa6960b0f60e67265c81bc9541 Mon Sep 17 00:00:00 2001 From: Henrik Skupin Date: Tue, 26 Apr 2022 09:42:42 +0200 Subject: [PATCH 4/4] chore: only run 100MB test --- test/evaluation.spec.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/evaluation.spec.ts b/test/evaluation.spec.ts index e3803d545d441..70ec402e9a47a 100644 --- a/test/evaluation.spec.ts +++ b/test/evaluation.spec.ts @@ -383,7 +383,8 @@ describe('Evaluation specs', function () { expect(result).toEqual([42]); } ); - it('should transfer 100Mb of data from page to node.js', async function () { + // eslint-disable-next-line mocha/no-exclusive-tests + it.only('should transfer 100Mb of data from page to node.js', async function () { const { page } = getTestState(); const a = await page.evaluate<() => string>(() =>