Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update setState to useState in markdown docs #334

Closed
wants to merge 2 commits into from
Closed

fix(docs): Update setState to useState in markdown docs #334

wants to merge 2 commits into from

Conversation

trybick
Copy link

@trybick trybick commented Oct 9, 2020

Fixes #325

When running the docs, this is giving an error. Not ready for review yet.

@trybick trybick requested a review from a team as a code owner October 9, 2020 23:59
Copy link
Contributor

@vine77 vine77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trybick! This is great work. You're right that it's a large issue. (In the future, I'm also going to add issues for converting class components to function components, so I'll make sure to split those up when I do.

I see what you mean regarding initialState. Styleguidist didn't actually require defining initialState, so for those examples, you can add something like const [value, setValue] = React.useState() without passing some initial state.

I added a commit to your branch fixing the issues for the ButtonSelect, Card, and Checkbox components. Feel free to take a look and pick up from there. If you can't get to it, I can do the rest eventually.

@vine77 vine77 mentioned this pull request Oct 14, 2020
1 task
@vine77 vine77 marked this pull request as draft November 11, 2020 17:14
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ vine77
❌ trybick
You have signed the CLA already but the status is still pending? Let us recheck it.

@vine77
Copy link
Contributor

vine77 commented Apr 22, 2021

Closing stale PRs for now.

@vine77 vine77 closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Styleguidist's initialState/setState to React's useState hook in docs
3 participants