Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider using os-specific delimiter in --include option #279

Open
hdgarrood opened this issue May 7, 2017 · 2 comments
Open

Reconsider using os-specific delimiter in --include option #279

hdgarrood opened this issue May 7, 2017 · 2 comments

Comments

@hdgarrood
Copy link
Collaborator

hdgarrood commented May 7, 2017

Currently pulp build --include foo:bar will attempt to include files from both foo and bar on linux and mac, but on windows it will look for a single directory called foo:bar. The separator is path.delimiter, i.e. colon on linux and mac, and semicolon on windows. This is a bit silly in retrospect. Not quite sure what to do about this right now but I'll leave this here and come back to it later.

@paulyoung
Copy link

FWIW I found this after trying pulp build --include foo --include bar which would be os-agnostic

@hdgarrood
Copy link
Collaborator Author

Allowing people to specify options like --include more than once is probably the most sensible thing to do, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants