Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pulp browserify #365

Open
hdgarrood opened this issue Jan 18, 2019 · 1 comment
Open

Deprecate pulp browserify #365

hdgarrood opened this issue Jan 18, 2019 · 1 comment

Comments

@hdgarrood
Copy link
Collaborator

At the moment, the difference between pulp build and pulp browserify is a little confusing, and I think complicates both the CLI and the actual implementation unnecessarily. Furthermore, I'm not sure that it makes sense for Pulp to consider whichever JS tools it's using for bundling part of its public API (whether that be browserify, parcel, rollup, webpack, whatever). Instead, I'd prefer that we deprecate pulp browserify, and replace it with a flag to pulp build which specifies whether Pulp should resolve any require calls while bundling. Ideally, we could do this in such a way that we'd be free to switch between different JS tools without downstream users having to care.

@hdgarrood
Copy link
Collaborator Author

Note also that at some stage, purs bundle is likely to be simplified so that it no longer does dead code elimination, or even becomes deprecated; this is part of why I'd like to do this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant