Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secure being on by default is dubious #39

Open
thomcc opened this issue Oct 12, 2020 · 2 comments
Open

secure being on by default is dubious #39

thomcc opened this issue Oct 12, 2020 · 2 comments

Comments

@thomcc
Copy link
Contributor

thomcc commented Oct 12, 2020

Safe rust code doesn't need the extra checking (statically known to be memory-safe), and the guard pages it uses can easily cause resource exhaustion to occur very early, which will cause an abort.

I've thought this for a while but figured I'd file an issue at least.

@octavonce
Copy link
Collaborator

@thomcc I initially thought that safe defaults are best. However, now I tend to agree with you. There are still benefits to using safe mode though, for example the myriad of unsafe code instances found in many libraries.

@samuelcolvin
Copy link

This should be closed, secure is no longer the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants