Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PR guidelines for DApp #1513

Closed
rohitmalhotra1420 opened this issue May 9, 2024 · 0 comments · Fixed by #1562
Closed

Create PR guidelines for DApp #1513

rohitmalhotra1420 opened this issue May 9, 2024 · 0 comments · Fixed by #1562
Assignees
@rohitmalhotra1420
Labels
documentation Improvements or additions to documentation

Comments

@rohitmalhotra1420
Copy link
Collaborator

rohitmalhotra1420 commented May 9, 2024 •
edited

Right now the pull request raised raised for the DApp doesn’t have any guidelines mentioned in the description.

The idea here is to create some sort of guidelines and for the developers so the pull request process is much easier and less time consuming. Developers could have an idea about the coding standards and the PR quality is improved.
@rohitmalhotra1420 rohitmalhotra1420 self-assigned this May 9, 2024
@rohitmalhotra1420 rohitmalhotra1420 added the documentation Improvements or additions to documentation label May 9, 2024
@rohitmalhotra1420 rohitmalhotra1420 linked a pull request May 22, 2024 that will close this issue
PR template added #1562
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohitmalhotra1420 rohitmalhotra1420

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PR template added push-protocol/push-dapp
1 participant
@rohitmalhotra1420