Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Faros should bail if parse errors occur #113

Open
wonderhoss opened this issue Mar 29, 2019 · 1 comment
Open

Faros should bail if parse errors occur #113

wonderhoss opened this issue Mar 29, 2019 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@wonderhoss
Copy link
Contributor

Currently, if a change to the yaml/json definition of a faros-managed object fails to parse, faros will no longer consider that object to be part of the repository and consequently delete it from the cluster.

In order to avoid applying partial state and potentially causing unwanted deletion of resources, faros should stop applying any chances for as long as there are parse errors anywhere within the repository(-path) and re-queue the GitTrack until the parse errors disappear.

@wonderhoss wonderhoss added the enhancement New feature or request label Mar 29, 2019
@tshak
Copy link
Contributor

tshak commented Mar 29, 2019

We certainly want to avoid deleting resources in this case. However, I strongly prefer a partial apply as opposed to aborting. The behavior should be to skip the problematic file(s) and/or object(s) and attempt to apply the rest of the repo/path. k8s desired state is not intended to be applied atomically. Imagine a critical change needing to go out while an ancillary change is causing the apply to break. This is also consistent with how kubectl apply -f <directory> behaves.

@JoelSpeed JoelSpeed added the bug Something isn't working label May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants