You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Currently, if a change to the yaml/json definition of a faros-managed object fails to parse, faros will no longer consider that object to be part of the repository and consequently delete it from the cluster.
In order to avoid applying partial state and potentially causing unwanted deletion of resources, faros should stop applying any chances for as long as there are parse errors anywhere within the repository(-path) and re-queue the GitTrack until the parse errors disappear.
The text was updated successfully, but these errors were encountered:
We certainly want to avoid deleting resources in this case. However, I strongly prefer a partial apply as opposed to aborting. The behavior should be to skip the problematic file(s) and/or object(s) and attempt to apply the rest of the repo/path. k8s desired state is not intended to be applied atomically. Imagine a critical change needing to go out while an ancillary change is causing the apply to break. This is also consistent with how kubectl apply -f <directory> behaves.
Currently, if a change to the yaml/json definition of a faros-managed object fails to parse, faros will no longer consider that object to be part of the repository and consequently delete it from the cluster.
In order to avoid applying partial state and potentially causing unwanted deletion of resources, faros should stop applying any chances for as long as there are parse errors anywhere within the repository(-path) and re-queue the GitTrack until the parse errors disappear.
The text was updated successfully, but these errors were encountered: