Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Support new Whisper Starter in CLI #4728

Closed
jgw96 opened this issue May 16, 2024 · 1 comment · Fixed by #4729
Closed

[CLI] Support new Whisper Starter in CLI #4728

jgw96 opened this issue May 16, 2024 · 1 comment · Fixed by #4729
Assignees
@jgw96
Labels
feature request 📬 in-progress

Comments

@jgw96
Copy link
Contributor

jgw96 commented May 16, 2024

Tell us about your feature idea

Users should have the "whisper" starter (https://github.com/pwa-builder/pwa-whisper-starter) as a template option.

Do you have an implementation or a solution in mind?

Yes, the Whisper starter should be added just like the normal starter.

Have you considered any alternatives?

No response
@jgw96 jgw96 self-assigned this May 16, 2024
@jgw96
Copy link
Contributor Author

jgw96 commented May 16, 2024

Started here https://github.com/pwa-builder/PWABuilder/tree/whisper-starter-cli, working with @zateutsch to finalize

@jgw96 jgw96 mentioned this issue May 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 20, 2024
@jgw96 @zateutsch
[CLI] Whisper Starter added to CLI (#4729)
a819e74 
fixes #4728 
<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

<!-- - Bugfix -->
Feature 
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->

## Describe the new behavior?
Whisper starter has been added as a starter option

## PR Checklist

- [x ] Test: run `npm run test` and ensure that all tests pass
- [ x] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [ x] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.


## Additional Information

---------

Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgw96 jgw96

Labels
feature request 📬 in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CLI] Whisper Starter added to CLI pwa-builder/PWABuilder
1 participant
@jgw96