Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (1117278) to head (9c03aa7).

@@            Coverage Diff             @@
##             main    #2622      +/-   ##
==========================================
+ Coverage   95.00%   95.08%   +0.07%     
==========================================
  Files          50       51       +1     
  Lines        8356     8478     +122     
  Branches     1673     1693      +20     
==========================================
+ Hits         7939     8061     +122     
- Misses        259      262       +3     
+ Partials      158      155       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

new test file:
Pages.62.73.from.0560-22_WSP.Plan_July.2022_Version.1.pdf

use of:
https://github.com/mozilla/pdf.js/blob/master/test/pdfs/bug1065245.pdf
as test input
8 images all looking like:

new test:
https://github.com/mozilla/pdf.js/blob/master/test/pdfs/bug1065245.pdf

image 0 :

@stefan6419846, @MartinThoma, @MasterOdin
In order to improve test coverage, I'm looking for PDF files with inline images. Can you provide me with some ?

It is rather unlikely that I am able to provide further (real) files for testing. While I have access to lots of PDF files in theory, most of them are confidential. Additionally, the usual routines I use completely omit any inline images as they provide no value for my use cases.

If possible, I would indeed prefer to avoid two different implementations of the same filter algorithms - we already have sufficient coverage for the filters outside the inline image extraction and thus re-using them would make more sense and avoid larger coverage issues.

@stefan6419846
thanks for trying.
There is not really changes in the filter/image processing. The change only applies to improve data extraction from contents.
Will try to find a way to generate some data.

add test file for RL encoding:
RL.pdf
image:

Besides the above remarks, there are two bigger issues I would like to talk about:

• Importing pypdf._xobj_image_helpers without Pillow is marked as deprecated. Why? Does this mean you want to completely drop support for installations without Pillow?
• Could we please use more verbose names for the filter methods while using all-lowercase function names as usually recommended by PEP8?