Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert_can_execute breaking api change with addition of env parameter #762

Open
bdoyle0182 opened this issue Nov 10, 2020 · 2 comments
Open

Comments

@bdoyle0182
Copy link

With the addition of the env parameter, any plugin that called assert_can_execute prior to this will be broken. I'm attempting to use the pybuilder-docker plugin and am facing this issue. Can we give env a default of None env=None so that it remains backwards compatible for plugins that were potentially already using it?

I created a pr for them to fix the issue, but I don't know if the plugin is being maintained or not.

for reference: AlienVault-Engineering/pybuilder-docker#7

@arcivanov
Copy link
Member

Thanks for the report. I'll see if it's possible to default to a specific environment as a reasonable default, but even then the system might not work.

@bdoyle0182
Copy link
Author

Thanks, yea I know it changed with a minor version so it's understandable that you're not responsible for dealing with it but it would be nice to have that default if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants