Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distutils build_binary_distribution should run before "package" not "publish" #886

Open
N3bukadne7ar opened this issue Mar 30, 2023 · 2 comments

Comments

@N3bukadne7ar
Copy link

The task dependency structure / naming when using distutils is a bit off.

When I want to use pybuilder to create e.g. a wheel file, the logical thing to do would be

pyb package

This is an empty task to be used by plugins to hook the actual tasks using dependency declarations. Distutils however hooks the package generation step to "publish" instead of "package"

On a related note: The step "upload" is exactly what I would associate with the term "publish". But "upload" is not hooked at all.

@arcivanov
Copy link
Member

On the first glance I agree with everything said here but for legacy reasons I don't think it's something that can really be changed.

@N3bukadne7ar
Copy link
Author

I understand, this would break probably almost all downstream projects. It is definitely not doable as a fix in a minor update or patch. Perhaps something to keep in mind for a future major update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants