Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --filter-files in options #1261

Closed
r-richmond opened this issue Jul 5, 2020 · 2 comments
Closed

Support --filter-files in options #1261

r-richmond opened this issue Jul 5, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@r-richmond
Copy link
Contributor

r-richmond commented Jul 5, 2020

According to http://timothycrosley.github.io/isort/docs/configuration/options/#filter-files is not supported in the config

Tells isort to filter files even when they are explicitly passed in as part of the command

Type: Bool
Default: False
Python & Config File Name: Not Supported
CLI Flags:

    --filter-files

I'd like to set this option in this config file so that all of my Isort configurations are in the same place.

My use case involves

  1. pre-commit hook
  2. PyCharm file watcher
  3. and just running isort ./**/*.py -c if I wanted.

Currently I have to remember to pass in --filter-files to these other tools otherwise files I want to exclude with be included. Instead I'd like to store all my Isort config files in one place and have that be respected.

p.s. the behavior in 5.0 where it loudly fails on the unsupported options is much better 👍 ty for adding that, I was going crazy on 4.x trying to figure out where I was messing up and now its much clear.

@timothycrosley timothycrosley added the enhancement New feature or request label Jul 5, 2020
@timothycrosley timothycrosley added this to the 5.2.0 milestone Jul 22, 2020
@timothycrosley
Copy link
Member

This was just deployed with version 5.2.0 of isort. Thanks!

~Timothy

@r-richmond
Copy link
Contributor Author

Hazaa, ty for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants