Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort is removing the new line after __version__ = "0.0.0" #1283

Closed
asheux opened this issue Jul 6, 2020 · 3 comments
Closed

isort is removing the new line after __version__ = "0.0.0" #1283

asheux opened this issue Jul 6, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@asheux
Copy link

asheux commented Jul 6, 2020

  • Before running isort
__version__ = "0.58.1"

from starlette import status
...
  • After running isort
__version__ = "0.58.1"
from starlette import status
@asheux asheux changed the title [QUESTION] isort is removing the new line after __version__ = "0.0.0". Is there any reason as to why? [QUESTION] isort is removing the new line after __version__ = "0.0.0"? Jul 6, 2020
@timothycrosley timothycrosley added the bug Something isn't working label Jul 7, 2020
@asheux asheux changed the title [QUESTION] isort is removing the new line after __version__ = "0.0.0"? isort is removing the new line after __version__ = "0.0.0" Jul 7, 2020
@jendrikseipp
Copy link

The same happens in 5.0.4 if there's an empty line between a comment and an import:

# My comment

import foo
import bar

But it seems you already fixed this in the development version @timothycrosley ?

@timothycrosley
Copy link
Member

@jendrikseipp yes that's right :)

I appreciate the report, the fix is now out in isort 5.0.5 patch release with additional regression testing in place

Thanks!

~Timothy

@jendrikseipp
Copy link

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants