Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort 5 no longer recognises sre_parse as a stdlib module #1304

Closed
Zac-HD opened this issue Jul 9, 2020 · 2 comments
Closed

isort 5 no longer recognises sre_parse as a stdlib module #1304

Zac-HD opened this issue Jul 9, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Jul 9, 2020

For example, sort

import re
import sre_constants
import sre_parse

and sre_parse will be placed in a new section, which is a regression from isort 4.3.21, where sre_parse was correctly treated as a stdlib module.

(and thanks for shipping isort 5! The new API is great for my shed project, and as a user I also really like the profile system 😄)

@timothycrosley timothycrosley added the bug Something isn't working label Jul 9, 2020
@timothycrosley
Copy link
Member

Thanks for reporting! This is fixed with an additional regression test added in 5.0.6. shed looks awesome! I'm glad you like the new release!

Thanks!

~Timothy

@Zac-HD
Copy link
Member Author

Zac-HD commented Jul 9, 2020

Wow! Awesomely fast response, and I'm similarly delighted that you like shed 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants