Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--combine-as loses # noqa #1321

Closed
scop opened this issue Jul 15, 2020 · 1 comment
Closed

--combine-as loses # noqa #1321

scop opened this issue Jul 15, 2020 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@scop
Copy link
Contributor

scop commented Jul 15, 2020

$ isort --version | grep VERSION
                    VERSION 5.1.0
$ cat t2.py 
from foo import *  # noqa
from foo import bar as quux  # noqa
$ isort --combine-as t2.py 
Fixing /tmp/t2.py
$ cat t2.py 
from foo import *  # noqa
from foo import bar as quux

# noqa on the from foo import bar as quux line was lost.

@timothycrosley timothycrosley added the bug Something isn't working label Jul 16, 2020
@timothycrosley timothycrosley added this to the 5.3.0 milestone Jul 31, 2020
@timothycrosley timothycrosley added the help wanted Extra attention is needed label Aug 5, 2020
@timothycrosley timothycrosley removed this from the 5.3.0 milestone Aug 5, 2020
sztamas added a commit to sztamas/isort that referenced this issue Aug 12, 2020
timothycrosley added a commit that referenced this issue Aug 13, 2020
@timothycrosley
Copy link
Member

This is fixed in 5.4.0

Thanks!

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants