Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two extra newlines before comment with -n --fss #1322

Closed
scop opened this issue Jul 15, 2020 · 1 comment
Closed

Two extra newlines before comment with -n --fss #1322

scop opened this issue Jul 15, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@scop
Copy link
Contributor

scop commented Jul 15, 2020

$ isort --version | grep VERSION
                    VERSION 5.1.0
$ cat t.py
import logging

# Comment canary
from foo import bar
import quux
$ isort -n --fss -d t.py
import logging



# Comment canary
from foo import bar
import quux

Two empty lines were insterted before the comment, but none should have been (i.e. the existing one should have been kept; no changes should have been made).

@timothycrosley
Copy link
Member

This is fixed in the just released 5.1.1 version: https://github.com/timothycrosley/isort/releases/tag/5.1.1

Thanks!

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants