Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 config cleanup #1350

Closed
sztamas opened this issue Jul 26, 2020 · 2 comments
Closed

Flake8 config cleanup #1350

sztamas opened this issue Jul 26, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sztamas
Copy link
Collaborator

sztamas commented Jul 26, 2020

Is there a good reason to ignore F401 globally in the project?

I got caught twice already by it, because I'm happy to have a successful ./scripts/done.sh but when I create a PR DeepSource marks my PR as failed because of an unused import.

I tend to use no global ignores for flake8 (just set a max line length) and manually mark the exceptions with # noqa: F401, etc.

Global ignores do save you the work to manually mark the exceptions but unfortunately as a side-effect mask all real problems as well.

@timothycrosley
Copy link
Member

There was no reason other then time, I'd be happy to have the process improved! I do think some, if not all, the other ignores are intentional to deal with black / isort formatting incompatibilities. But identifying the ones that are necessary and the ones that aren't would also be helpful, and once complete the script could be commented to mention they are intentional and why

@timothycrosley timothycrosley added enhancement New feature or request help wanted Extra attention is needed labels Jul 26, 2020
@sztamas sztamas changed the title Flake8 global ignore for F401 unused import Flake8 config cleanup Jul 27, 2020
@sztamas
Copy link
Collaborator Author

sztamas commented Jul 27, 2020

Hi @timothycrosley,

This should be done now. See: #1351

Thanks,

Tamas

@sztamas sztamas closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants