Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Known other does not work anymore with .editorconfig #1383

Closed
erdnaxeli opened this issue Aug 13, 2020 · 1 comment
Closed

Known other does not work anymore with .editorconfig #1383

erdnaxeli opened this issue Aug 13, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@erdnaxeli
Copy link

Hi,

The doc says we can use know_something in the config file: https://timothycrosley.github.io/isort/docs/configuration/options/#known-other. There is no example for editorconfig but it used to work on 4.x branch. It does not work anymore because of this line: https://github.com/timothycrosley/isort/blob/develop/isort/settings.py#L657. As the key cannot be in _DEFAULT_SETTINGS, it is dropped.

Thanks.
@timothycrosley timothycrosley added the bug Something isn't working label Aug 14, 2020
timothycrosley added a commit that referenced this issue Aug 14, 2020
@timothycrosley
#1383: Known other does not work anymore with .editorconfig
ed22d44
@timothycrosley
Copy link
Member

Thanks for reporting! This has been fixed in isort 5.4.2

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erdnaxeli @timothycrosley