isort: off not working

[chdsbd]

I was having trouble getting the isort: off comment to work. I was able to get it to work in another file, but not in this example.

# isort: off
from app.resources import (
    db,
    cache
)
# isort: on

.isort.cfg

[settings]
profile=black

./.venv/bin/isort main.py --diff output

--- /Users/chris/projects/isort-reproduction/main.py:before	2020-08-21 12:12:04.127048
+++ /Users/chris/projects/isort-reproduction/main.py:after	2020-08-21 12:14:49.983382
@@ -1,6 +1,4 @@
 # isort: off
-from app.resources import (
-    db,
-    cache
-)
+from app.resources import cache, db
+
 # isort: on

example repository: https://github.com/chdsbd/isort-reproduction

---

EDIT: strangely if I add two # to the top of the file this issue disappears:

#
#

# isort: off
from app.resources import (
    db,
    cache
)
# isort: on

[timothycrosley]

Hi @chdsbd,

Thanks for reporting! Thanks to your bug report, this has been fixed in develop and will make it's way out in the next release of isort.

Background info: isort is very cautious with the top comment of a file, since it can contain execution information, encoding info, etc... This is a case where it still makes sense to to act off that comment, but just in case you were curious as to the why behind why it would work, except for this very specific case.

Thanks!

~Timothy

[chdsbd]

Thanks for the quick fix!

[timothycrosley]

This change has just been deployed to PyPI in version 5.5.0

Thanks!

~Timothy