Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipped path can be removed from dirnames twice #1399

Closed
magicl opened this issue Aug 21, 2020 · 2 comments
Closed

skipped path can be removed from dirnames twice #1399

magicl opened this issue Aug 21, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@magicl
Copy link

magicl commented Aug 21, 2020

In function iter_source_code, if a path is_skipped, and is also in visited_dirs, it will be removed from dirnames twice.

This happens if you have symbolic links in code, causing loops, and then try to disable these links using the "-s" parameter to isort.

Would be good to have an option to isort to prevent following symbolic links as well.

@timothycrosley timothycrosley added the bug Something isn't working label Aug 22, 2020
@timothycrosley
Copy link
Member

@magicl,

Thanks for reporting this issue! It has been fixed in develop and will be pushed to PyPI in the 5.5.0 release.

Thanks!

~Timothy

@timothycrosley
Copy link
Member

This change has just been deployed to PyPI in version 5.5.0

Thanks!

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants