Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coloring to --diff output #1405

Closed
GergelyKalmar opened this issue Aug 24, 2020 · 5 comments · Fixed by #1409
Closed

Add coloring to --diff output #1405

GergelyKalmar opened this issue Aug 24, 2020 · 5 comments · Fixed by #1409
Assignees
@sztamas
Labels
enhancement New feature or request
Milestone
5.5.0

Comments

@GergelyKalmar
Copy link

Although I was very excited to try out the color output config option (now that pylint allows isort >= 5), it does not seem to do all that much at the moment. In particular, I have expected that diffs will be nicely colored just like they are with git diff, but that does not seem to be the case. Am I missing something or is this not implemented yet?

Thank you!
@timothycrosley timothycrosley added the enhancement New feature or request label Aug 25, 2020
@timothycrosley
Copy link
Member

You are right, it is very limited in scope at the moment! Hopefully overtime it will become more comprehensive. For now, we will prioritize adding the color output to diffs.

Thanks!

~Timothy

@sztamas sztamas self-assigned this Aug 25, 2020
sztamas added a commit that referenced this issue Aug 25, 2020
@sztamas
Adds colors to --diff output.
1371f04 
Resolves #1405
@sztamas sztamas mentioned this issue Aug 25, 2020
Merged
@timothycrosley
Copy link
Member

This is now implemented in develop (thanks @sztamas!) and will make it's way out in the 5.5.0 release of isort which is slated for release by September 1st.

@timothycrosley timothycrosley added this to the 5.5.0 milestone Aug 26, 2020
@GergelyKalmar
Copy link
Author

Amazing, thank you both very much!

@timothycrosley
Copy link
Member

This change has just been deployed to PyPI in version 5.5.0

Thanks!

~Timothy

@GergelyKalmar
Copy link
Author

Works great, thank you!

@neutrinoceros neutrinoceros mentioned this issue Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sztamas sztamas

Labels
enhancement New feature or request
Projects
None yet
Milestone
5.5.0
Development

Successfully merging a pull request may close this issue.

Adds colors to --diff output. PyCQA/isort
3 participants
@sztamas @timothycrosley @GergelyKalmar