Do not cache configuration files #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaste
force-pushed
the
less-cache
branch
2 times, most recently
from
e19356f
to
37a6187
Compare
Fixes PyCQA#1994 isort can run in long processes when used in an editor. In that scenario it is confusing for users when editing a configuration file does not change isorts outcome. Remove the caches in `settings.py` completely to re-read the configuration on each run. This is safe for the CLI case as we here either use the `Trie` implementation which collects all known configuration files beforehand, or we exactly construct one `Config` object based on the first filename, the working dir, or the explicit `settings_path|file` settings. Not caching is therefore more efficient for the CLI case and more useful for the editor case.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1995 +/- ##
==========================================
- Coverage 99.22% 99.22% -0.01%
==========================================
Files 38 38
Lines 3091 3087 -4
Branches 747 747
==========================================
- Hits 3067 3063 -4
Misses 14 14
Partials 10 10 |
|
@timothycrosley Sorry for the delayed rebase and actually making it green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1994
isort can run in long processes when used in an editor. In that scenario it is confusing for users when editing a configuration file does not change isorts outcome.
Remove the caches in
settings.pycompletely to re-read the configuration on each run.This is safe for the CLI case as we here either use the
Trieimplementation which collects all known configuration files beforehand, or we exactly construct oneConfigobject based on the first filename, the working dir, or the explicitsettings_path|filesettings.Not caching is therefore more efficient for the CLI case and more useful for the editor case.