Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deprecated extras #2089

Merged
merged 4 commits into from Feb 21, 2023
Merged

Cleanup deprecated extras #2089

merged 4 commits into from Feb 21, 2023

Conversation

staticdev
Copy link
Collaborator

@staticdev staticdev commented Feb 9, 2023

Some code of extras was not completely removed leading to issues from users. This PR is a further cleanup.

Closes #2088

@staticdev staticdev added the removal Removals and deprecations label Feb 9, 2023
@staticdev staticdev changed the title Cleanup deprecated extras WIP: Cleanup deprecated extras Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #2089 (869dc58) into main (4114c33) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2089   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          38       38           
  Lines        3087     3087           
  Branches      747      747           
=======================================
  Hits         3063     3063           
  Misses         14       14           
  Partials       10       10           

@staticdev staticdev changed the title WIP: Cleanup deprecated extras Cleanup deprecated extras Feb 10, 2023
@staticdev staticdev merged commit 7024ceb into main Feb 21, 2023
@staticdev staticdev deleted the removal/unused-extras branch February 21, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal Removals and deprecations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING: isort 5.12.0 does not provide the extra....
2 participants