Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too broad warning about missing toml package #902

Closed
gcolombeau opened this issue Mar 15, 2019 · 1 comment
Closed

Too broad warning about missing toml package #902

gcolombeau opened this issue Mar 15, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@gcolombeau
Copy link

The warning about the missing toml package is not restrictive enough in my opinion. At the moment, it is issued every time a pyproject.toml file is detected even if there is no specific configuration in it for isort. I don't use the isort package but I use pylint and this behavior adds a lot of noise to the output.

Would it be possible to improve this by first checking if the toml file contains an uncommented line [tool.isort] to not issue the warning if one does not want to specify some configuration in this file?

https://github.com/timothycrosley/isort/blob/f76f312abc804fc6bbd2dddf76a11581dda4cb32/isort/settings.py#L342-L354

@timothycrosley timothycrosley added the enhancement New feature or request label Mar 24, 2019
@timothycrosley
Copy link
Member

This should be fixed in the latest release: https://github.com/timothycrosley/isort/releases/tag/4.3.16

Thanks!

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants