Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to provide a way to skip passed in files against filters #938

Closed
timothycrosley opened this issue May 1, 2019 · 1 comment
Closed

Comments

@timothycrosley
Copy link
Member

From gitter:

Hey! I have a kind of missunderstanding.
I'm using isort on pre commit hook.
isort config:

line_length = 88
multi_line_output = 4
lines_after_imports = 2
skip_glob =
    migrations/**

and it works for isort -c -rc
but for pre commit hook migrations/** is being ignored 'cause it passes the file pass explictly like
isort migrations/versions/1234.py and that ignores skip_glob
is there a way to fix or workaround this behavior?
basically, I would like skip_glob to match even if file was provided explicitly using its full path

@timothycrosley
Copy link
Member Author

Fixed in latest release (4.3.18) via the addition of a --filter-files command line option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant