Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect .gitignore #960

Closed
fpuga opened this issue Jun 20, 2019 · 4 comments
Closed

Respect .gitignore #960

fpuga opened this issue Jun 20, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@fpuga
Copy link

fpuga commented Jun 20, 2019

To avoid (miss)configurations it will be awesome that isort ignore by default the patterns set in .gitignore.

Other projects like black are also thinking on doing it.

@mdagaro
Copy link

mdagaro commented Jun 26, 2019

I'm interested in taking up this issue if it's okay @timothycrosley

@timothycrosley
Copy link
Member

@mdagaro, it would be very appreciated, thank you!

mdagaro pushed a commit to mdagaro/isort that referenced this issue Aug 9, 2019
Add flag -git/--exclude-gitignore to ignore files found in a .gitignore.
Throws an exception if it is not a git repository.
mdagaro pushed a commit to mdagaro/isort that referenced this issue Aug 9, 2019
Add flag -git/--exclude-gitignore to ignore files found in a .gitignore.
Throws an exception if it is not a git repository.
mdagaro pushed a commit to mdagaro/isort that referenced this issue Aug 9, 2019
Add flag -git/--exclude-gitignore to ignore files found in a .gitignore.
@timothycrosley timothycrosley added the enhancement New feature or request label Jan 6, 2020
@timothycrosley timothycrosley added this to the 5.0.0 milestone Feb 17, 2020
@timothycrosley timothycrosley removed this from the 5.0.0 milestone Jul 4, 2020
timothycrosley added a commit that referenced this issue Jul 22, 2020
timothycrosley added a commit that referenced this issue Jul 22, 2020
@timothycrosley
Copy link
Member

This is implemented in the develop branch (Thanks @mdagaro!) and will be deployed with the 5.2.0 minor release.

@timothycrosley
Copy link
Member

This was just deployed with version 5.2.0 of isort. Thanks!

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants