Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in public type names / method names: peak -> peek? #50

Closed
decathorpe opened this issue Dec 2, 2023 · 2 comments · Fixed by #48
Closed

typo in public type names / method names: peak -> peek? #50

decathorpe opened this issue Dec 2, 2023 · 2 comments · Fixed by #48

Comments

@decathorpe
Copy link
Contributor

It looks like there's a typo in the name of one public enum (Peak) and one public method (Jiter::peak):

Reading the documentation for what that type / method does, I suppose they should be named Peek / peek instead?

Here's the corresponding trait from the Rust standard library:
https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html

@samuelcolvin
Copy link
Member

Weird, I thought I already noticed this and fixed, apparently not.

PR welcome to correct this.

@samuelcolvin
Copy link
Member

You're right, it should definitely be "peek"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants