Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country specific types #35

Open
hirotasoshu opened this issue May 5, 2023 · 5 comments
Open

Country specific types #35

hirotasoshu opened this issue May 5, 2023 · 5 comments

Comments

@hirotasoshu
Copy link
Contributor

hirotasoshu commented May 5, 2023

In #30, the ABARouting number was implemented, which is used only in US banks.
In this regard, I have a question/suggestion: maybe it is worth putting the types that are specific to some countries/regions in separate modules or even in separate packages?
Personally, I prefer the idea of separate packages for different countries, it's easier to maintain. We can create a template that is divided into modules depending on the area of life.
@yezz123 what do you think?

@yezz123
Copy link
Collaborator

yezz123 commented May 7, 2023

Hey @hirotasoshu !

I can't mainly understand what you mean by :

it is worth putting the types that are specific to some countries/regions in separate modules or even in different packages?

because right now mostly we can do a country as an entry point and then we can add other countries's banks

@hirotasoshu
Copy link
Contributor Author

hirotasoshu commented May 9, 2023

@yezz123 That's roughly what I meant, not just for banks, but also for other types, such as postal code, taxpayer identification number, and more

because right now mostly we can do a country as an entry point and then we can add other countries's banks

At this moment, it is possible to divide into entry points in this package, but as the package grows, it will be more difficult to maintain. Therefore, I proposed to separate such types into separate packages that could be maintaned by residents of different countries (for example, types specific to the United States by residents of the United States), and leave only types that are not tied to the specifics of certain countries in this package.

@linpan
Copy link

linpan commented Jul 11, 2023

metoo, i will clone this repo, and develop based on the repo.

@linpan
Copy link

linpan commented Jul 11, 2023

@yezz123 passport number based on country.

@hirotasoshu
Copy link
Contributor Author

@yezz123 I found a reference to make it clearer what I meant: https://github.com/django/django-localflavor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants