-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Country specific types #35
Comments
Hey @hirotasoshu ! I can't mainly understand what you mean by :
because right now mostly we can do a country as an entry point and then we can add other countries's banks |
@yezz123 That's roughly what I meant, not just for banks, but also for other types, such as postal code, taxpayer identification number, and more
At this moment, it is possible to divide into entry points in this package, but as the package grows, it will be more difficult to maintain. Therefore, I proposed to separate such types into separate packages that could be maintaned by residents of different countries (for example, types specific to the United States by residents of the United States), and leave only types that are not tied to the specifics of certain countries in this package. |
metoo, i will clone this repo, and develop based on the repo. |
@yezz123 passport number based on country. |
@yezz123 I found a reference to make it clearer what I meant: https://github.com/django/django-localflavor |
In #30, the ABARouting number was implemented, which is used only in US banks.
In this regard, I have a question/suggestion: maybe it is worth putting the types that are specific to some countries/regions in separate modules or even in separate packages?
Personally, I prefer the idea of separate packages for different countries, it's easier to maintain. We can create a template that is divided into modules depending on the area of life.
@yezz123 what do you think?
The text was updated successfully, but these errors were encountered: