New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow usage of with_config
on a Pydantic model
#9398
Disallow usage of with_config
on a Pydantic model
#9398
Conversation
CodSpeed Performance ReportMerging #9398 will not alter performanceComparing Summary
|
26fff66
to
47e7993
Compare
Waiting for directions regarding the |
Changes look good. Hmm, I can take an in-depth look at the test failure this afternoon... |
Will approve once tests pass, but looks great otherwise :) |
Additionally, make `is_pydantic_dataclass` argument pos only, this was missed from a previous PR.
51c7b60
to
2928dde
Compare
Looks great - please resolve conflicts :). Will merge after that! |
Ah, I resolved the conflicts, looked like super minor git problems haha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick change request for tests
Yep was expected with the other PR merged, thanks for wrapping up! |
Additionally, make
is_pydantic_dataclass
argument pos only, this was missed from a previous PR.Fixes #9397