Lexer for new language Maxima #1885
Merged
+604
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anteru
requested changes
Aug 16, 2021
added 11 commits
August 22, 2021 09:54
* New lexer class MaximaLexer * Update _mapping.py to include Maxima lexer * New test input file maxima/foo.mac I find that the commands $ python3 -m pygments -O full -f html -o /tmp/foo.html tests/examplefiles/maxima/foo.mac $ python3 -m pygments -x -l pygments/lexers/maxima.py:MaximaLexer tests/examplefiles/maxima/foo.mac both produce expected output.
Commit output from pytest tests/examplefiles/maxima --update-goldens as obtained by Cameron Smith.
all at once, instead of capturing each character separately. Update expected output for example input file, as produce by: $ pytest tests/examplefiles/maxima --update-goldens
instead of just calling them Text.
as Punctuation instead of Text.
…gs such as operators via the words function, instead of a long regex with alternation. Incidentally update the example output, for which one symbol (namely "done") has changed classification.
…e output accordingly.
so integers are more accurately identified. Update test example output accordingly.
Include additional test input for floats and update expected output.
added 2 commits
August 22, 2021 17:37
(1) adjust package name underline (2) put in copyright notice
|
Hi @Anteru I'm sorry for the bother, but can I ask you to review this PR again? I made the changes you requested (and some other improvements as well). |
|
I'll take another look this weekend. Please keep in mind that the next release will be in 2-3 months so it'll be a while until you'll see this packaged in a PyPI release. |
Sounds good, you can let me know how it goes. There's no hurry, I just want to make sure the wheels are in motion. Thanks a lot for your help. |
|
Merged, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a Pygments lexer for Maxima, a computer algebra system. See: https://maxima.sourceforge.io
The Maxima lexer is derived from the lexer for MuPAD, another computer algebra system.
The PR contains the lexer implementation and an example input, foo.mac, and its expected output from pytest --update-goldens.