Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pygmentize
was hanging or taking minutes to parse certain GSQL code.Syntax changes include: adding [], <>, and _ (square brackets, angle brackets and single underscore) to the Punctuation class.
The test for that fix is now include in
tests/examplefiles/gsql/test.gsql
A one-liner to test for that fix:
CREATE QUERY tg_astar (VERTEX source_vertex, VERTEX target_vertex, SET<STRING> e_type, STRING wt_type, STRING latitude, STRING longitude,
The string regex was causing backtracking in some cases - simplified here.
In GSQL DDL, parameter such as
$0
,$"fieldname"
and_
to indicate empty position are possible. They were being flagged as errors. The test for that change is also added to thetest.gsql
fileA one-liner to test the DDL syntax fix:
LOAD Inventory TO EDGE in_warehouse_inventory VALUES($"warehouse", $1, $_)
Reusing edge names for multiple usage requires using pipe as an operator. Pipe is now added to that section.
Test case was added to
test.gsql
A one-liner test for edge name reuse :
ADD UNDIRECTED EDGE in_code(FROM City, TO PostalCode | FROM Correspondence, TO PostalCode | FROM Address, TO PostalCode);