formatters/img: use new API for bounding box for Pillow 9.2 #2198
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked at this a bit and was confused by how characters are measured. Is this use of getbbox equivalent to how getsize was used before, e.g. does it handle the height of descenders (as in ‘q’ or ‘g’) the same way? If so LGTM. |
|
TBH I just looked at https://pillow.readthedocs.io/en/stable/_modules/PIL/ImageFont.html#ImageFont.getsize which shows that all of the three methods (getsize, getbbox, getlength) use the same underlying API... |
Anteru
reviewed
Aug 14, 2022
| return self.fonts['NORMAL'].getsize(text) | ||
| font = self.fonts['NORMAL'] | ||
| if hasattr(font, 'getbbox'): # Pillow >= 9.2.0 | ||
| return font.getbbox(text)[2:4] |
There was a problem hiding this comment.
Suggested change
| return font.getbbox(text)[2:4] | |
| return font.getlength(text) |
There was a problem hiding this comment.
If I read the docs correctly, getlength only returns a single value, while getsize returns (width, height).
Anteru
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.