Remove unneeded _format_unencoded_with_lineno function from IRCFormatter #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a dedicated test which highlights one of the bugs you'd have with that previously? |
…ter and fix line endings insertion
Ayowel
force-pushed
the
fix/ircformatter
branch
from
1e2a56e
to
e61134b
Compare
|
@Anteru Done, see The old version would put the line-end |
Anteru
added
the
changelog-update
|
Thanks for your contribution! |
jeanas
removed
the
changelog-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
_format_unencoded_with_linenofromIRCFormatterto avoid code duplication and fix a bug where the newline and the linenumber would be inserted too early.