Fix parsing of dns zone record line succeeding record with comment #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
reviewed
Nov 26, 2023
pygments/lexers/dns.py
Outdated
| 'multiple-simple-values': [ | ||
| include('simple-value'), | ||
| (r'[\n]+', Whitespace), | ||
| (r'[ \t]+', Whitespace), |
There was a problem hiding this comment.
Aren't these two just \s+?
Also, simple-value already includes a rule for [ \t]+.
There was a problem hiding this comment.
Yes, you are correct. The last line should not have been included in the final revision. Sorry!
An updated version is available.
There was a problem hiding this comment.
@birkenfeld is there anything else I can do to help getting this merged?
Previously, the second line was treated as continuing Literals following 192.0.2.4 delta A 192.0.2.4 ; comment delta2 A 192.0.2.5
johnbergvall
force-pushed
the
dns-zone-tweaks
branch
from
cf560a3
to
d1e47fb
Compare
|
Sorry, dropped the ball. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tweak of #2464
Previously, the second line was treated as a series of Literals following 192.0.2.4, instead of a separate record line