Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: use consistent (ideally, portable) fileseps on Windows #8004

Open
bersbersbers opened this issue Oct 12, 2023 · 1 comment
Labels
feature Feature request

Comments

@bersbersbers
Copy link
Contributor

On Windows, pyi-makespec --splash sub/x.png sub/x.py outputs:

a = Analysis(
    ['sub\\x.py'],
    ...

splash = Splash(
    'sub/x.png',
    ...
  1. File system separators are not consistent: "\\" != "/"
  2. File system separators are not portable: this .spec file cannot be used on Linux.

I suggest that all fileseps be replaced by /, which should work on all OSes.

@bersbersbers bersbersbers added feature Feature request triage Please triage and relabel this issue labels Oct 12, 2023
@rokm
Copy link
Member

rokm commented Oct 13, 2023

That's a good point - especially the non-portability of the .spec.

We could probably re-purpose the existing escape_win_filepath to replace the \ with / instead of \\.

This is also a good opportunity to fix the .spec templates to use %r for string formatting in general, as I suspect unpleasant happen if a string (a path, or application name, or anything really) contains an '.

@rokm rokm removed the triage Please triage and relabel this issue label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants