Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bad code smell for open without encoding= #3897

Closed
FredHappyface opened this issue Oct 13, 2020 · 2 comments
Closed

Add bad code smell for open without encoding= #3897

FredHappyface opened this issue Oct 13, 2020 · 2 comments

Comments

@FredHappyface
Copy link

Is your feature request related to a problem? Please describe

A clear and concise description of what the problem is.

Python on Windows defaults to an encoding that differs to the standard utf-8 on other platforms (pretty sure it's code page 1525 or something like that). This often means that my code contains bugs that are only triggered under Windows. Having looked into this, it seems to be a pretty common issue and it looks like PSF are reluctant to set the default to uft-8 on all platforms...

Describe the solution you'd like

A clear and concise description of what you want to happen.

I would very much appreciate it if pylint was willing to add a bad code smell or similar level finding for functions such as open, Popen lacking a user defined encoding

Additional context

Add any other context about the feature request here.

Thanks for this fantastic project

@FredHappyface
Copy link
Author

My bad looks like I missed

#3826

@hippo91
Copy link
Contributor

hippo91 commented Oct 17, 2020

@FredHappyface no pb! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants