Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR830 pause buffer #985

Open
FlyingCurryMonster opened this issue Nov 2, 2023 · 5 comments
Open

SR830 pause buffer #985

FlyingCurryMonster opened this issue Nov 2, 2023 · 5 comments
Labels
bug diagnosed Solution proposed, needs implementation instrument

Comments

@FlyingCurryMonster
Copy link

FlyingCurryMonster commented Nov 2, 2023

I'm trying to diagnose some digitization issues on my SR830 and noticed there's a bug related to pauseBuffer(). In the SR830 py file there are several cases where self.pause_buffer() is used, when the actual function call should be "self.pauseBuffer()".

Edit: It also seems like the buffer_data() method isn't defined in the SR830 class.

@BenediktBurger
Copy link
Member

Yes, indeed. 8 years ago pauseBuffer was renamed to pause_buffer, but not all occurrences.

Would you mind fixing it? If you need help with it, we're here.

@BenediktBurger BenediktBurger added bug diagnosed Solution proposed, needs implementation instrument labels Nov 3, 2023
@FlyingCurryMonster
Copy link
Author

FlyingCurryMonster commented Nov 3, 2023

For sure. It seems like the support for measurements with the buffer isn't too well supported at the moment. That's not too surprising, I didn't need it until I ran into issues where my device noise is lower than the resolution of the SR830.
I'm guessing the workaround for digitization is to use the SR830 buffer and fast sample rate to record ~1000 measurements in the buffer and take the mean of the buffer, rather than record the front reading. I think by central limit theorem (I think?) that should cure the quantization problem.

I'll try and fix the pause and the buffer measure methods.

Any input or thoughts are appreciated. I also accidentally closed this issue.

@BenediktBurger
Copy link
Member

Any input or thoughts are appreciated

For the naming, pause_buffer is the better name, as that is the normal python naming scheme.

Regarding the buffer_data, I don't know anything

@seb5g
Copy link
Contributor

seb5g commented Dec 15, 2023

Hi guys,
I'm actually working on making this driver working again. Indeed the buffer_data was not defined... I should be done with a first update soon

@BenediktBurger
Copy link
Member

Thanks for your comment @seb5g.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug diagnosed Solution proposed, needs implementation instrument
Projects
None yet
Development

No branches or pull requests

3 participants