Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: --only shouldn't require prerelease pythons setting #1564

Merged
merged 2 commits into from Aug 14, 2023
Merged

fix: --only shouldn't require prerelease pythons setting #1564

merged 2 commits into from Aug 14, 2023

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Aug 7, 2023

Fix #1560.

@henryiii
fix: --only shouldn't require prerelease pythons setting
141ac5c 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@mayeut
Copy link
Member

mayeut commented Aug 8, 2023

should a test be added to unit_test/main_tests/main_platform_test.py ?

@joerick
Copy link
Contributor

joerick commented Aug 8, 2023 •
edited

Yeah, that's probably a good idea. It would need a mock of BuildSelector.PRERELEASE_SKIP. Given that I'll probably release 2.15 today without any prerelease_skip versions there's no reason to rush this.

@henryiii henryiii merged commit ce71f44 into pypa:main Aug 14, 2023
23 checks passed
@henryiii henryiii deleted the henryiii/fix/onlypre branch August 14, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerick joerick joerick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--only shouldn't require CIBW_PRERELEASE_PYTHONS
3 participants
@henryiii @mayeut @joerick