Test that find_library_file works with Cygwin libraries #139
Conversation
It worked for setuptools<60 and doesn't with setuptools>=60; I would like it to keep working.
|
Cygwin test failing in the expected place; adding the fix from #140 to make sure the fix works, and consolidate PR work. I'm not sure whether all of those patterns should be in there; it depends on what This PR is now a full replacement for pypa/setuptools#3304. |
- `/usr/lib/lib${name}.a` Static library, needed at link time, embedded for run time
- `/usr/lib/lib${name}.dll.a` Import library, needed at link time, sets up run-time redirections to DLL
- `/usr/bin/cyg${name}.dll` Dynamically-linked library, needed at run time. Extension used for python C extension modules.
Replaces pypa#140
|
The new test passes with the library name pattern update. Merging this should probably wait for input from a maintainer about what The |
I'm not aware of anyone with the context to address this question. If the code itself can't answer the question, then I'm not confident anyone can. I'm going to merge the change and hope it has the desired effects. |
|
Worst case for the problem I'm thinking of involves the linker failing, and I think those error messages are decently informative, so that's a reasonable approach. |
It worked for setuptools<60 and doesn't with setuptools>=60; I would like it to keep working.
Follow-up to python-pillow/Pillow#6216
This is one of the patches mentioned in #73 (comment)