Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"invalid-publisher: valid token, but no corresponding publisher" error, nothing changed on our side #180

Closed
ryanblock opened this issue Aug 16, 2023 · 5 comments · Fixed by pypi/warehouse#14374
Assignees
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@ryanblock
Copy link

ryanblock commented Aug 16, 2023

Hello there! Regarding this particular error publishing via OIDC I've already read over: #138, #173 (and the lesser relevant #154, #166) and wasn't able to determine a fix in this case.

I don't really have repro steps here, other than:

  • Yesterday: OIDC publishing via GitHub Actions worked, I went to sleep
  • Today: publishing is no longer working 😅

I didn't change anything on our side, just going about our regular business of committing changes and publishing. Links:

Here's the relevant block in our GitHub Actions file jic.

Thanks for your attention! 💕

@webknjaz webknjaz added help wanted Extra attention is needed question Further information is requested labels Aug 17, 2023
@webknjaz
Copy link
Member

@di @woodruffw could you take a look? The error implies the env check failure, but the workflow doesn't use envs.

@di
Copy link
Sponsor Member

di commented Aug 17, 2023

Looking into this now.

@di
Copy link
Sponsor Member

di commented Aug 17, 2023

Fix is here: pypi/warehouse#14374

@ryanblock
Copy link
Author

Woo, nice job on the quick patch. Re-ran the last failed build, and that build is no longer failing. 💯

@woodruffw
Copy link
Member

woodruffw commented Aug 17, 2023

Hmm, looks like another unexpected claim change on GitHub's part -- I guess environment is now always present with ""?

Edit: Ignore me, I see the change was purely on the Warehouse side with pypi/warehouse#14372.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants