Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifier < that contains prerelease version does not match on valid prerelease versions #788

Open
notatallshaw opened this issue Mar 26, 2024 · 3 comments · May be fixed by #794
Open

Specifier < that contains prerelease version does not match on valid prerelease versions #788

notatallshaw opened this issue Mar 26, 2024 · 3 comments · May be fixed by #794
Labels
bug packaging.specifiers

Comments

@notatallshaw
Copy link

notatallshaw commented Mar 26, 2024 •
edited

This relates to this part of the spec:

The exclusive ordered comparison <V MUST NOT allow a pre-release of the specified version unless the specified version is itself a pre-release. Allowing pre-releases that are earlier than, but not equal to a specific pre-release may be accomplished by using <V.rc1 or similar.

So, for example, <3.0.0a8 is a prerelease specifier, and therefore falls under "unless the specified version is itself a pre-release", I would expect it to then "Allowing pre-releases that are earlier than, but not equal to a specific pre-release", for example 3.0.0a7.

However that does not appear to be the case:

>>> from packaging.specifiers import Specifier
>>> Specifier('<3.0.0a8').contains("3.0.0a7")
False
>>> Specifier('<=3.0.0a8').contains("3.0.0a7")
True

This came up in astral-sh/uv#2646 and I'm aware of the comment #776 (comment), but the spec seems very explicit and even gives an examples that < allows prereleases when the version itself is a prerelease.
@notatallshaw notatallshaw mentioned this issue Mar 26, 2024
Closed
@notatallshaw notatallshaw changed the title SpecifierSets that contains prerelease does not match on valid prerelease SpecifierSet that contains prerelease version does not match on valid prerelease versions Mar 26, 2024
@notatallshaw notatallshaw changed the title SpecifierSet that contains prerelease version does not match on valid prerelease versions Specifier < that contains prerelease version does not match on valid prerelease versions Mar 26, 2024
@notatallshaw
Copy link
Author

notatallshaw commented Mar 26, 2024 •
edited

Interestingly the spec talks about < in relation to prerelease, and > in releation to post releases, and I see > does follow the spec here:

>>> Specifier('>3.0.0post1').contains("3.0.0post2")
True

However, unless I am missing it, the spec fails to mention how to handle < with post releases, or > with prereleases, e.g. should >3.0.0a8 match 3.0.0a9 or <3.0.0post2 match 3.0.0post1?

@uranusjr
Copy link
Member

Personally I don’t see how those combinations should be treated differently from those explicitly mentioned in the spec.

@notatallshaw
Copy link
Author

Personally I don’t see how those combinations should be treated differently from those explicitly mentioned in the spec.

In that case the common theme is that packaging is violating the spec for prereleases, but not for postreleases:

>>> Specifier('>3.0.0a8').contains("3.0.0a9")
False
>>> Specifier('<3.0.0post2').contains("3.0.0post1")
True

This was referenced Apr 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug packaging.specifiers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix prerelease detection for > and < notatallshaw/packaging
3 participants
@uranusjr @pradyunsg @notatallshaw