Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge with pypa/distutils@75ed79d #3366

Merged
merged 31 commits into from
Jun 12, 2022
Merged

Merge with pypa/distutils@75ed79d #3366

merged 31 commits into from
Jun 12, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Jun 12, 2022

  • TST: Test that find_library_file works with Cygwin libs
  • Update name patterns for Cygwin libraries.
  • Fixed case of CC config variable not being defined.
  • Fix finding headers when cross compiling
  • Move more of the GCC detection to the is_gcc method.
  • Remove check for undefined CC var.
  • Inline the first option.
  • Update Python versions to include Python 3.11.
  • Remove tests for SO config var, no longer present in Python 3.11.
  • Mark test as xfail. Ref easy_install (via bdist_egg) adds __init__.py to PEP 420 namespace packages #148.
  • 👹 Feed the hobgoblins (delint).
  • Add flake8 config from jaraco/skeleton for compatibility with black.
  • Skip string normalization when using black.
  • ⚫ Fade to black.
  • 👹 Feed the hobgoblins (delint).
  • Remove compatibility for Python 3.5 (except tests).
  • Remove compatibility for Python 3.5 in tests.
  • Avoid re-using 'prefix' variable.
  • Extract separate functions for get_python_inc{os.name}, now that OS treatment diverges even more.
  • Extract functions for _get_python_inc for config or prefix variants. Use value algebra to simplify the logic.
  • ⚫ Fade to black.
  • ⚫ Fade to black.
  • Extract function for posix python build.

Summary of changes

Closes

Pull Request Checklist

DWesl and others added 30 commits May 4, 2022 12:16
@DWesl
TST: Test that find_library_file works with Cygwin libs
722f192 
It worked for setuptools<60 and doesn't with setuptools>=60; I would like it to keep working.
@DWesl
Update name patterns for Cygwin libraries.
c6f28fc 
- `/usr/lib/lib${name}.a` Static library, needed at link time, embedded for run time
- `/usr/lib/lib${name}.dll.a` Import library, needed at link time, sets up run-time redirections to DLL
- `/usr/bin/cyg${name}.dll` Dynamically-linked library, needed at run time.  Extension used for python C extension modules.

Replaces #140
@jaraco
Merge pull request #139 from DWesl/patch-2
27638e3 
Test that find_library_file works with Cygwin libraries
@MilchRatchet
Fixed case of CC config variable not being defined.
0f5c4bd
@lopsided98
Fix finding headers when cross compiling
aed7294 
When cross-compiling third-party extensions, get_python_inc() may be called to
return the path to Python's headers. However, it uses the sys.prefix or
sys.exec_prefix of the build Python, which returns paths pointing to build
system headers when instead we really want the host system headers.

To fix this, we use the INCLUDEPY and CONFINCLUDEPY conf variables, which can
be configured to point at host Python by setting _PYTHON_SYSCONFIGDATA_NAME.
The existing behavior is maintained on non-POSIX platforms or if a prefix is
manually specified.
@jaraco
Move more of the GCC detection to the is_gcc method.
036ad4b
@jaraco
Remove check for undefined CC var.
c96b9db
@jaraco
Inline the first option.
5b814f7
@jaraco
Merge pull request #144 from MilchRatchet/main
3f6a9ad 
Fixed Issue on Windows+MSYS2 with unsafe handling of CC config variable.
@jaraco
Update Python versions to include Python 3.11.
6d01e89
@jaraco
Remove tests for SO config var, no longer present in Python 3.11.
053740f
@jaraco
Mark test as xfail. Ref #148.
1da8e75
@jaraco
Merge pull request #147 from pypa/feature/py311
ad9b074 
Add testing for Python 3.11
@jaraco
👹 Feed the hobgoblins (delint).
4b587ed
@jaraco
Add flake8 config from jaraco/skeleton for compatibility with black.
255926c
@jaraco
Skip string normalization when using black.
3eee97a
@jaraco
⚫ Fade to black.
ab77f7d
@jaraco
👹 Feed the hobgoblins (delint).
c7db899
@jaraco
Remove compatibility for Python 3.5 (except tests).
03998e6
@jaraco
Remove compatibility for Python 3.5 in tests.
262768b
@jaraco
Merge pull request #149 from pypa/debt/delint
147379a 
Do some delinting
@jaraco
Avoid re-using 'prefix' variable.
b05a823
@jaraco
Extract separate functions for _get_python_inc_{os.name}, now that OS…
4266782 
… treatment diverges even more.
@jaraco
Extract functions for _get_python_inc for config or prefix variants. …
fabd05a 
…Use value algebra to simplify the logic.
@jaraco
⚫ Fade to black.
e5b02d2
@jaraco
Merge branch 'main' into python-inc-cross
bf901de
@jaraco
⚫ Fade to black.
43b424b
@jaraco
Extract function for posix python build.
26607e1
@jaraco
Merge pull request #145 from lopsided98/python-inc-cross
75ed79d 
Fix finding headers when cross compiling
@jaraco
Merge pypa/distutils@75ed79d
423f182
@jaraco jaraco merged commit eb75ea6 into main Jun 12, 2022
@jaraco jaraco deleted the feature/distutils-75ed79d branch June 12, 2022 23:42
@DWesl DWesl mentioned this pull request Jun 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaraco @DWesl @MilchRatchet @lopsided98