Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNT: Add pylint & address issues #909

Merged
merged 17 commits into from Aug 24, 2021
Merged

LNT: Add pylint & address issues #909

merged 17 commits into from Aug 24, 2021

Conversation

snowman2
Copy link
Member

  • Fully documented, including history.rst for all changes and api/*.rst for new API

@snowman2 snowman2 added this to In progress in 3.2.0 Release via automation Aug 23, 2021
@snowman2 snowman2 force-pushed the pylint2 branch 2 times, most recently from 9a9c4b8 to 861c959 Compare August 24, 2021 00:04
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #909 (8fc174c) into master (f1f784a) will increase coverage by 0.57%.
The diff coverage is 98.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
+ Coverage   95.60%   96.18%   +0.57%     
==========================================
  Files          21       21              
  Lines        1730     1755      +25     
==========================================
+ Hits         1654     1688      +34     
+ Misses         76       67       -9     
Impacted Files Coverage Δ
pyproj/_show_versions.py 86.04% <ø> (ø)
pyproj/crs/coordinate_operation.py 100.00% <ø> (ø)
pyproj/enums.py 100.00% <ø> (ø)
pyproj/transformer.py 94.68% <95.65%> (+0.02%) ⬆️
pyproj/__main__.py 98.27% <96.77%> (+0.09%) ⬆️
pyproj/utils.py 82.45% <97.14%> (+0.97%) ⬆️
pyproj/geod.py 97.38% <98.68%> (+6.16%) ⬆️
pyproj/__init__.py 89.47% <100.00%> (ø)
pyproj/aoi.py 100.00% <100.00%> (ø)
pyproj/crs/__init__.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f784a...8fc174c. Read the comment docs.

@snowman2 snowman2 changed the title LNT: Add pylint LNT: Add pylint & address issues Aug 24, 2021
@snowman2 snowman2 marked this pull request as ready for review August 24, 2021 00:23
@snowman2 snowman2 merged commit c4cdc33 into pyproj4:master Aug 24, 2021
3.2.0 Release automation moved this from In progress to Done Aug 24, 2021
@snowman2 snowman2 deleted the pylint2 branch August 24, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant