Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests use out list instead of results file + patching echo #241

Open
yaythomas opened this issue Nov 9, 2021 · 0 comments
Open
Labels
enhancement new features

Comments

@yaythomas
Copy link
Member

Some of the integration tests are fairly slow & this gets annoying during dev cycles.

Especially the integration tests that read expected output from a _expected file can rewire instead to check a list from the result context, assuming the test pipelines replace pypyr.steps.echo with pypyr.steps.append. This saves at least one file PER TEST being read from disk during test runs.

This can be an incremental task. For starters, will just focus on the slowest offenders - which is tests/integrations/pypyr/call/loopcallnested_int_test.py. These are the only tests that use assert_pipeline_raises_match_file.

Other integration tests that just intercepts echo can also use the pypyr.steps.append technique - these will be updated incrementally over time.

@yaythomas yaythomas added the enhancement new features label Nov 9, 2021
@yaythomas yaythomas added this to To do in pypyr roadmap via automation Nov 9, 2021
@yaythomas yaythomas changed the title integration tests use out list instead of patching echo integration tests use out list instead of results file + patching echo Nov 9, 2021
yaythomas added a commit that referenced this issue Nov 9, 2021
…eline_raises_match_file update to use assert against list in code instead. ref #241.
yaythomas added a commit that referenced this issue Nov 20, 2021
…eline_raises_match_file update to use assert against list in code instead. ref #241.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new features
Projects
pypyr roadmap
  
To do
Development

No branches or pull requests

1 participant