Patch methods should return AsyncMock if the target is an async method

[GDYendell]

This would match the behaviour of the equivalent methods in mock

Currently, I can pass new_callable=AsyncMock to make it work, but then mypy type checking fails because the type hints state that the methods return MagicMock. The return type is a union in the mock stubs.

[nicoddemus]

Hi @GDYendell, thanks for bringing this to attention.

[nicoddemus]

Hi @GDYendell,

There's a PR for this in #364, but I wonder if you could post an example of a mypy failure? See my comments in #364 (comment).

[GDYendell]

Hi @nicoddemus

This was a while ago now so I am doing some digging trying to remember. There is a chain of issues that leads to testing-cabal/mock#500 where I included a mypy error.

The repo this was happening is https://github.com/dls-controls/odinprocservcontrol. I have created a mypy branch from an old commit to recreate the problem here. It works on master with the updated types-mock. If it is useful to recreate the problem locally, checkout the mypy branch and do a pipenv install --dev --ignore-pipfile and pipenv run mypy tests.

I have briefly looked through #364, but don't immediately understand the detail of the change - is this useful information? Let me know if there is anything else I can do to help.