Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pytest-dev/pytest-xdist
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.6.0
Choose a base ref
...
head repository: pytest-dev/pytest-xdist
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.6.1
Choose a head ref
  • 6 commits
  • 5 files changed
  • 4 contributors

Commits on Apr 19, 2024

  1. Merge pull request #1070 from pytest-dev/release-3.6.0

    Release 3.6.0
    bluetech authored Apr 19, 2024
    Copy the full SHA
    699f939 View commit details

Commits on Apr 23, 2024

  1. [pre-commit.ci] pre-commit autoupdate (#1073)

    updates:
    - [github.com/astral-sh/ruff-pre-commit: v0.3.7 → v0.4.1](astral-sh/ruff-pre-commit@v0.3.7...v0.4.1)
    
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    pre-commit-ci[bot] authored Apr 23, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    52e2022 View commit details
  2. build(deps): bump hynek/build-and-inspect-python-package (#1066)

    Bumps the github-actions group with 1 update: [hynek/build-and-inspect-python-package](https://github.com/hynek/build-and-inspect-python-package).
    
    
    Updates `hynek/build-and-inspect-python-package` from 2.2 to 2.4
    - [Release notes](https://github.com/hynek/build-and-inspect-python-package/releases)
    - [Changelog](https://github.com/hynek/build-and-inspect-python-package/blob/main/CHANGELOG.md)
    - [Commits](hynek/build-and-inspect-python-package@v2.2...v2.4)
    
    ---
    updated-dependencies:
    - dependency-name: hynek/build-and-inspect-python-package
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: github-actions
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Apr 23, 2024
    Copy the full SHA
    c93a106 View commit details

Commits on Apr 28, 2024

  1. Cache execnet gateway rinfo during WorkerController setup

    Cache execnet gateway info during WorkerController setup for backward
    compatibility, in order to avoid a later main_thread_only deadlock
    error triggered when pytest-cov calls rinfo after the main thread is
    already busy. See pytest-dev/execnet#274 for corresponding test case.
    
    Fixes: 20e3ac7 ("Use execnet main_thread_only execmodel (#1027)")
    zmedico authored and bluetech committed Apr 28, 2024
    Copy the full SHA
    12b3cce View commit details
  2. Merge pull request #1072 from zmedico/gateway-cache-rinfo

    Cache execnet gateway rinfo during WorkerController setup
    bluetech authored Apr 28, 2024
    Copy the full SHA
    b397288 View commit details
  3. Release 3.6.1

    bluetech committed Apr 28, 2024
    Copy the full SHA
    4dd2978 View commit details
Showing with 18 additions and 3 deletions.
  1. +1 −1 .github/workflows/deploy.yml
  2. +1 −1 .github/workflows/test.yml
  3. +1 −1 .pre-commit-config.yaml
  4. +10 −0 CHANGELOG.rst
  5. +5 −0 src/xdist/workermanage.py
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4

- name: Build and Check Package
uses: hynek/build-and-inspect-python-package@v2.2
uses: hynek/build-and-inspect-python-package@v2.4

deploy:
needs: package
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Build and Check Package
uses: hynek/build-and-inspect-python-package@v2.2
uses: hynek/build-and-inspect-python-package@v2.4

test:

2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: "v0.3.7"
rev: "v0.4.1"
hooks:
- id: ruff
args: ["--fix"]
10 changes: 10 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
pytest-xdist 3.6.1 (2024-04-28)
===============================

Bug Fixes
---------

- `#1071 <https://github.com/pytest-dev/pytest-xdist/issues/1071>`_: Add backward compatibility for deadlock issue with the ``execnet`` new ``main_thread_only`` "execmodel" triggered when pytest-cov accesses rinfo.

pytest-xdist 3.6.0 (2024-04-19)
===============================

This release was YANKED due to a regression fixed in 3.6.1.

Features
--------

5 changes: 5 additions & 0 deletions src/xdist/workermanage.py
Original file line number Diff line number Diff line change
@@ -312,6 +312,11 @@ def shutting_down(self) -> bool:

def setup(self) -> None:
self.log("setting up worker session")
# Cache rinfo for backward compatibility, since pytest-cov
# accesses rinfo while the main thread is busy executing our
# remote_exec call, which triggers a deadlock error for the
# main_thread_only execmodel if the rinfo has not been cached.
self.gateway._rinfo()
spec = self.gateway.spec
args = [str(x) for x in self.config.invocation_params.args or ()]
option_dict = {}