Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8516 fix causes other issues elsewhere #10757

Closed
cjw296 opened this issue Feb 22, 2023 · 1 comment
Closed

#8516 fix causes other issues elsewhere #10757

cjw296 opened this issue Feb 22, 2023 · 1 comment

Comments

@cjw296
Copy link

cjw296 commented Feb 22, 2023

8516 includes a hard coded ~0o077:

https://github.com/pytest-dev/pytest/pull/8516/files#diff-10ee70cc91700b16983baadc71b08d4239920ea83c1041a06adbb4302ae80c5bR145

This is also arguably wrong in that it re-permissions a directory potentially not even created by the current text (think pytest-xdist, etc) and breaks some existing use cases for these fixtures...

In our case, we have tests that ssh to localhost as a different user to the one running the tests and then work inside a directory created inside the one created by the tmp_path fixtures. Since this change, those tests are broken and we can no longer use the tmp_path fixture as a result.

Please could this specific change be reverted or, alternatively, something added so that we can turn this off?

@RonnyPfannschmidt
Copy link
Member

closing as duplicate of #10738

@BeyondEvil started working on a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants