Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect codeblock escape for file contents/file paths in eval #2461

Open
wookie184 opened this issue Mar 10, 2023 · 3 comments
Open

Detect codeblock escape for file contents/file paths in eval #2461

wookie184 opened this issue Mar 10, 2023 · 3 comments
Labels
a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) status: approved The issue has received a core developer's approval t: bug Something isn't working

Comments

@wookie184
Copy link
Contributor

When sending text from stdout (correctly detected):
image

When sending text from a file (not detected):
image

This is also an issue for the file names.
@wookie184 wookie184 added t: bug Something isn't working s: planning Discussing details a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) labels Mar 10, 2023
@mbaruh
Copy link
Member

mbaruh commented Mar 11, 2023

Backticks can removed from filenames. As for file contents, if detected I think it should just post a link to the pastebin.

@wookie184 wookie184 added status: approved The issue has received a core developer's approval and removed s: planning Discussing details labels Mar 21, 2023
@TizzySaurus
Copy link
Contributor

TizzySaurus commented Mar 30, 2023 •
edited

Can I please be assigned to this? I can even implement this as part of my solution to #2492.

@TizzySaurus
Copy link
Contributor

TizzySaurus commented May 2, 2023 •
edited

...I can even implement this as part of my solution to #2492.

In hindsight, I think it'll be better to keep them isolated, so I'll be doing a separate PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) status: approved The issue has received a core developer's approval t: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbaruh @wookie184 @TizzySaurus