Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the resource topic when using the !resources command #2510

Open
n0Oo0Oo0b opened this issue Apr 5, 2023 · 1 comment
Open

Display the resource topic when using the !resources command #2510

n0Oo0Oo0b opened this issue Apr 5, 2023 · 1 comment
Labels
s: stalled Something is blocking further progress status: approved The issue has received a core developer's approval

Comments

@n0Oo0Oo0b
Copy link
Contributor

The !resources command accepts an optional argument to specify the resource topic in the URL. For example, !resources data science will result in the following link: https://www.pythondiscord.com/resources/?topics=data-science

However, there is no difference in the embed (other than the hyperlink itself) to indicate that a topic has been specified. I propose that when a topic is specified, it will be added to the title of the embed, like "Resources for: Data science".

(I would like to implement this myself)

@hedyhli
Copy link
Member

hedyhli commented Mar 23, 2024

Ideally, we would want to check for the command arguments against the list of valid filters (see the above linked issue - or python-discord/site#710). So once we have that endpoint on the site, we can then add in the "Resources for: " if the argument is a valid topic, and just the current normal "Resources" title otherwise.

@wookie184 wookie184 added s: stalled Something is blocking further progress status: approved The issue has received a core developer's approval labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: stalled Something is blocking further progress status: approved The issue has received a core developer's approval
Projects
None yet
Development

No branches or pull requests

3 participants